-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
19.2.0-beta.20190930 Release Notes #5250
Conversation
2058254
to
a45aad9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @lhirata)
releases/v19.2.0-beta.20190826.md, line 41 at r1 (raw file):
### General changes - Replicas are now added using a raft learner and go through the normal raft snapshot process to catch them up, eliminating technical debt. No user facing changes are expected. [#39034][#39034]
Raft
should be capitalized.
releases/v19.2.0-beta.20190826.md, line 52 at r1 (raw file):
I'd rephrase this to be simpler:
Renamed
SHOW EXPERIMENTAL_RANGES
toSHOW RANGES
.
Is there something to say about this statement no longer being experimental, or is that obvious?
releases/v19.2.0-beta.20190826.md, line 54 at r1 (raw file):
- Removed `EXPERIMENTAL_` and `TESTING_` prefixes from the [`SHOW EXPERIMENTAL_RANGES`](../v19.2/show-experimental-ranges.html) command. [#39153][#39153] - Added partial support for row limits during portal execution in `pgwire`. [#39085][#39085] - Added a `LITY` command in [`cockroach sql`](../v19.2/use-the-built-in-sql-client.html). [#39058][#39058]
What does this command do? Can we summarize? Also, does this belong in "Command-line updates" instead of SQL updates?
releases/v19.2.0-beta.20190826.md, line 57 at r1 (raw file):
- Added support for a `SHOW PARTITIONS` command. [#39053][#39053] - [`CREATE VIEW`](../v19.2/create-view.html) now supports all queries supported by the optimizer, including those containing [correlated subqueries](../v19.2/subqueries.html#correlated-subqueries). [#39169][#39169] - Mutations are no longer allowed inside [views](../v19.2/views.html). [#39169][#39169]
Is this a breaking change? If so, it should be in a "Backwards-incompatible changes" section, which should be the first section.
releases/v19.2.0-beta.20190826.md, line 58 at r1 (raw file):
- [`CREATE VIEW`](../v19.2/create-view.html) now supports all queries supported by the optimizer, including those containing [correlated subqueries](../v19.2/subqueries.html#correlated-subqueries). [#39169][#39169] - Mutations are no longer allowed inside [views](../v19.2/views.html). [#39169][#39169] - Added the `COLLATION FOR` syntax and `pg_collation_for` builtin function. [#39198][#39198]
builtin
> built-in
releases/v19.2.0-beta.20190826.md, line 59 at r1 (raw file):
- Mutations are no longer allowed inside [views](../v19.2/views.html). [#39169][#39169] - Added the `COLLATION FOR` syntax and `pg_collation_for` builtin function. [#39198][#39198] - Implemented the `timezone()` builtin and `AT TIME ZONE` syntax, which allows converting a `timestamptz` into a `timezone` at a specified timezone, and converting a `timestamp` into a `timestamptz` at a specified timezone. [#39186][#39186]
builtin
> built-in
releases/v19.2.0-beta.20190826.md, line 60 at r1 (raw file):
- Added the `COLLATION FOR` syntax and `pg_collation_for` builtin function. [#39198][#39198] - Implemented the `timezone()` builtin and `AT TIME ZONE` syntax, which allows converting a `timestamptz` into a `timezone` at a specified timezone, and converting a `timestamp` into a `timestamptz` at a specified timezone. [#39186][#39186] - Added a `SHOW RANGES FROM DATABASE` command. [#39194][#39194]
Ideally, this should combined with the bullet about renaming SHOW EXPERIMENTAL RANGES
, or at least come directly after.
releases/v19.2.0-beta.20190826.md, line 61 at r1 (raw file):
I'd rephrase a little:
The new
vectorized_row_count_threshold
cluster setting controls...
releases/v19.2.0-beta.20190826.md, line 62 at r1 (raw file):
- Added a `SHOW RANGES FROM DATABASE` command. [#39194][#39194] - CockroachDB now has `vectorize_row_count_threshold` [cluster setting](../v19.2/cluster-settings.html) that controls when the vectorized execution engine is used. [#39329][#39329] - Added a `EXPLAIN(VEC)` command to show detailed plan information for vectorized plans. [#39280][#39280]
Is EXPLAIN(VEC)
considered an entirely new statement, or is VEC
just yet another EXPLAIN
option?
releases/v19.2.0-beta.20190826.md, line 64 at r1 (raw file):
- Added a `EXPLAIN(VEC)` command to show detailed plan information for vectorized plans. [#39280][#39280] - Partition names can now be reused between different indexes on the same table. [#39332][#39332] - Columns without an explicit default value now support foreign keys with the SET DEFAULT action, in the same way as the SET NULL and `SET DEFAULT NULL` cases. [#39136][#39136]
Put backticks around SET DEFAULT
and SET NULL
.
releases/v19.2.0-beta.20190826.md, line 87 at r1 (raw file):
- [`cockroach start`](../v19.2/start-a-node.html) now writes the client URL to the file specified via `--listen-url-file` as soon as the server is ready to accept connections. This also happens before the server detaches from the terminal when `--background` is specified. [#39300][#39300] - The [`cockroach user`](../v19.2/create-and-manage-users.html) sub-commands are now deprecated. Users and roles can be managed using SQL statements instead. This functionality will be removed in the next release. [#39297][#39297] - CockroachDB will now check that the value passed via the `--cluster-name` [flag](../v19.2/start-a-node.html#flags), if provided, matches when a node connects to a cluster. This feature is meant for use in combination with the cluster ID, which is still checked in any case, to protect newly created nodes (that don't have a cluster ID yet) from joining the wrong cluster. To introduce a cluster name into an existing cluster without one, the new flag can be temporarily paired with `--disable-cluster-name-verification`. [#39270][#39270]
This and the next bullet are phrased awkwardly. Can you rephrase to something like: "The new --cluster name
flag..." and "The new --sql-address
flag..."?
releases/v19.2.0-beta.20190826.md, line 89 at r1 (raw file):
- CockroachDB will now check that the value passed via the `--cluster-name` [flag](../v19.2/start-a-node.html#flags), if provided, matches when a node connects to a cluster. This feature is meant for use in combination with the cluster ID, which is still checked in any case, to protect newly created nodes (that don't have a cluster ID yet) from joining the wrong cluster. To introduce a cluster name into an existing cluster without one, the new flag can be temporarily paired with `--disable-cluster-name-verification`. [#39270][#39270] - CockroachDB now recognizes a [flag](../v19.2/start-a-node.html#flags) `--sql-addr` which makes it possible to accept connections by clients on a separate TCP address and/or port number from the one used for intra-cluster (node-node) connections. This is aimed to enable firewalling client traffic from server traffic. [#39305][#39305] - Added an option to set node localities in [`cockroach demo`](../v19.2/cockroach-demo.html). [#39454][#39454]
Can you state the new flag? Also, it'd be ideal to combine this with the other cockroach demo
changes, or at least group them together.
releases/v19.2.0-beta.20190826.md, line 101 at r1 (raw file):
- Properly initialize proposal quota tracking to prevent quota leak which can hang imports or other AddSSTable operations. [#39135][#39135] - `crdb_internal.ranges` can now be used inside [views](../v19.2/views.html). Note that such views can become invalid in future releases if `crdb_internal.ranges` changes. [#39195][#39195] - Prevent panic due to recording into finished tracing spans caused by acknowledging an earlier failed re-proposal when a later re-proposal exists. [#39203][#39203]
Prevent > Prevented
releases/v19.2.0-beta.20190826.md, line 112 at r1 (raw file):
### Performance improvements - Speed up file-writing during bulk-ingestion. [#37528][#37528]
Speed > Sped
releases/v19.2.0-beta.20190826.md, line 117 at r1 (raw file):
- Adjusted load-based splitting QPS threshold to avoid over-splitting. [#39687][#39687] #### Performance improvment
Remove this duplicate heading and combine the single bullet with the list above.
releases/v19.2.0-beta.20190826.md, line 124 at r1 (raw file):
- Added an [Oracle migration guide](../v19.2/migrate-from-oracle.html), which guides users through the process of converting their schema and then exporting their data so they can load it into CockroachDB via [`IMPORT`](../v19.2/import.html).
A few more doc updates:
- Added an overview of MovR, CockroachDB's fictional vehicle-sharing dataset and application, and updated several SQL pages and examples to use the built-in MovR dataset, for example, Learn CockroachDB SQL. #5075, #5216
- Added a tutorial on using
EXPLAIN
to identify and resolve common SQL performance problems. #5178
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @jseldess and @lhirata)
releases/v19.2.0-beta.20190826.md, line 41 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Raft
should be capitalized.
Done.
releases/v19.2.0-beta.20190826.md, line 52 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
I'd rephrase this to be simpler:
Renamed
SHOW EXPERIMENTAL_RANGES
toSHOW RANGES
.Is there something to say about this statement no longer being experimental, or is that obvious?
I'll add clarification
releases/v19.2.0-beta.20190826.md, line 54 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
What does this command do? Can we summarize? Also, does this belong in "Command-line updates" instead of SQL updates?
This seems to be a typo. Should be SHOW LOCALITY
releases/v19.2.0-beta.20190826.md, line 57 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Is this a breaking change? If so, it should be in a "Backwards-incompatible changes" section, which should be the first section.
Radu says this is something that shouldn't have been allowed in the first place, and that it's technically a breaking change, but only if you were doing something crazy to begin with.
@jseldess, do you think it needs more info here?
releases/v19.2.0-beta.20190826.md, line 58 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
builtin
>built-in
Done.
releases/v19.2.0-beta.20190826.md, line 59 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
builtin
>built-in
Done.
releases/v19.2.0-beta.20190826.md, line 61 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
I'd rephrase a little:
The new
vectorized_row_count_threshold
cluster setting controls...
Done.
releases/v19.2.0-beta.20190826.md, line 62 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Is
EXPLAIN(VEC)
considered an entirely new statement, or isVEC
just yet anotherEXPLAIN
option?
New option. Edited the sentence
releases/v19.2.0-beta.20190826.md, line 64 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Put backticks around
SET DEFAULT
andSET NULL
.
Done.
releases/v19.2.0-beta.20190826.md, line 87 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
This and the next bullet are phrased awkwardly. Can you rephrase to something like: "The new
--cluster name
flag..." and "The new--sql-address
flag..."?
Done.
releases/v19.2.0-beta.20190826.md, line 89 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Can you state the new flag? Also, it'd be ideal to combine this with the other
cockroach demo
changes, or at least group them together.
Reorganized.
releases/v19.2.0-beta.20190826.md, line 101 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Prevent > Prevented
Done.
releases/v19.2.0-beta.20190826.md, line 112 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Speed > Sped
Done.
releases/v19.2.0-beta.20190826.md, line 117 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Remove this duplicate heading and combine the single bullet with the list above.
Done.
releases/v19.2.0-beta.20190826.md, line 124 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
A few more doc updates:
- Added an overview of MovR, CockroachDB's fictional vehicle-sharing dataset and application, and updated several SQL pages and examples to use the built-in MovR dataset, for example, Learn CockroachDB SQL. #5075, #5216
- Added a tutorial on using
EXPLAIN
to identify and resolve common SQL performance problems. #5178
Done.
3f46ebc
to
559294a
Compare
bf5e5aa
to
0b4ca42
Compare
@jseldess, can you review the new additions? |
7866fe0
to
f831422
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with some nits and minor comments
releases/v19.2.0-beta.20190826.md
Outdated
<a href="https://binaries.cockroachdb.com/cockroach-v19.2.0-beta.20190826.linux-amd64.tgz"><button id="linux" data-eventcategory="linux-binary-release-notes">Linux</button></a> | ||
<a href="https://binaries.cockroachdb.com/cockroach-v19.2.0-beta.20190826.src.tgz"><button id="source" data-eventcategory="source-release-notes">Source</button></a> | ||
<a href="https://binaries.cockroachdb.com/cockroach-v19.2.0-beta-20190903.darwin-10.9-amd64.tgz"><button id="mac" data-eventcategory="mac-binary-release-notes">Mac</button></a> | ||
<a href="https://binaries.cockroachdb.com/cockroach-vv19.2.0-beta-20190903.linux-amd64.tgz"><button id="linux" data-eventcategory="linux-binary-release-notes">Linux</button></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra v
from vv19
.
releases/v19.2.0-beta.20190826.md
Outdated
@@ -84,6 +84,13 @@ $ docker pull cockroachdb/cockroach-unstable:v19.2.0-beta.20190826 | |||
- CockroachDB now supports an optional frame exclusion clause in the specification of window frames. [#28262][#28262] {% comment %}doc{% endcomment %} | |||
- Enabled collection of histograms by default during automatic statistics collection. [#39743][#39743] | |||
- The `force_retry()` function, which previously required admin privileges, is now available to all users to test their transaction retry loops. [#39246][#39246] {% comment %}doc{% endcomment %} | |||
- When [`DROP CONSTRAINT`](../v19.2/drop-constraint) is executed in a [transaction](../v19.2/transaction.html) on a validated constraint, it no longer takes effect immediately, and subsequent writes in that constraint will now fail if they violate that constraint. This is to enforce consistency when dropping constraints asynchronously in the schema changer. [#39648][#39648] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should subsequent writes in that constraint
be shorted to just subsequent writes
..?
releases/v19.2.0-beta.20190826.md
Outdated
@@ -84,6 +84,13 @@ $ docker pull cockroachdb/cockroach-unstable:v19.2.0-beta.20190826 | |||
- CockroachDB now supports an optional frame exclusion clause in the specification of window frames. [#28262][#28262] {% comment %}doc{% endcomment %} | |||
- Enabled collection of histograms by default during automatic statistics collection. [#39743][#39743] | |||
- The `force_retry()` function, which previously required admin privileges, is now available to all users to test their transaction retry loops. [#39246][#39246] {% comment %}doc{% endcomment %} | |||
- When [`DROP CONSTRAINT`](../v19.2/drop-constraint) is executed in a [transaction](../v19.2/transaction.html) on a validated constraint, it no longer takes effect immediately, and subsequent writes in that constraint will now fail if they violate that constraint. This is to enforce consistency when dropping constraints asynchronously in the schema changer. [#39648][#39648] | |||
- The `ALTER PARTITION` [statement](../v19.2/sql-statements.html) now supports applying a [zone configuration](../v19.2/configure-replication-zones.html) to all the partitions of a table and its indexes that share the same partition name. The syntax for this is `ALTER PARTITION <partition name> OF INDEX <table name>@*`. [#39750][#39750] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For ALTER PARTITION
, I think we should link to configure-zone.html
.
releases/v19.2.0-beta.20190826.md
Outdated
- The `ALTER PARTITION` [statement](../v19.2/sql-statements.html) now supports applying a [zone configuration](../v19.2/configure-replication-zones.html) to all the partitions of a table and its indexes that share the same partition name. The syntax for this is `ALTER PARTITION <partition name> OF INDEX <table name>@*`. [#39750][#39750] | ||
- Support parsing the `FOR UPDATE` modifier on [`SELECT`](../v19.2/select-clause.html) clauses, treating it as a no-op, since CockroachDB's [transactions](../v19.2/transactions.html) only operate in `SERIALIZABLE` mode. [#40206][#40206] | ||
- [`SHOW PARTITIONS`](../v19.2/show-partitions.html) now shows the full zone configuration statement used to configure the partition. [#39814][#39814] | ||
- Added the `pg_my_temp_schema` [built-in](../v19.2/functions-and-operators.html) for Postgres compatibility. [#40194][#40194] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: pg_my_temp_schema()
releases/v19.2.0-beta.20190826.md
Outdated
- Support parsing the `FOR UPDATE` modifier on [`SELECT`](../v19.2/select-clause.html) clauses, treating it as a no-op, since CockroachDB's [transactions](../v19.2/transactions.html) only operate in `SERIALIZABLE` mode. [#40206][#40206] | ||
- [`SHOW PARTITIONS`](../v19.2/show-partitions.html) now shows the full zone configuration statement used to configure the partition. [#39814][#39814] | ||
- Added the `pg_my_temp_schema` [built-in](../v19.2/functions-and-operators.html) for Postgres compatibility. [#40194][#40194] | ||
- Added the overlaps (`&&`), contains (`@>`) and contained_by (`<@`) operators for [arrays](../v19.2/array.html). [#40194][#40194] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Add oxford comma
releases/v19.2.0-beta.20190826.md
Outdated
- [`SHOW PARTITIONS`](../v19.2/show-partitions.html) now shows the full zone configuration statement used to configure the partition. [#39814][#39814] | ||
- Added the `pg_my_temp_schema` [built-in](../v19.2/functions-and-operators.html) for Postgres compatibility. [#40194][#40194] | ||
- Added the overlaps (`&&`), contains (`@>`) and contained_by (`<@`) operators for [arrays](../v19.2/array.html). [#40194][#40194] | ||
- Added `pg_get_function_identity_arguments` [built-in](../v19.2/functions-and-operators.html). [#40194][#40194] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: pg_get_function_identity_arguments()
releases/v19.2.0-beta.20190826.md
Outdated
@@ -84,6 +84,13 @@ $ docker pull cockroachdb/cockroach-unstable:v19.2.0-beta.20190826 | |||
- CockroachDB now supports an optional frame exclusion clause in the specification of window frames. [#28262][#28262] {% comment %}doc{% endcomment %} | |||
- Enabled collection of histograms by default during automatic statistics collection. [#39743][#39743] | |||
- The `force_retry()` function, which previously required admin privileges, is now available to all users to test their transaction retry loops. [#39246][#39246] {% comment %}doc{% endcomment %} | |||
- When [`DROP CONSTRAINT`](../v19.2/drop-constraint) is executed in a [transaction](../v19.2/transaction.html) on a validated constraint, it no longer takes effect immediately, and subsequent writes in that constraint will now fail if they violate that constraint. This is to enforce consistency when dropping constraints asynchronously in the schema changer. [#39648][#39648] | |||
- The `ALTER PARTITION` [statement](../v19.2/sql-statements.html) now supports applying a [zone configuration](../v19.2/configure-replication-zones.html) to all the partitions of a table and its indexes that share the same partition name. The syntax for this is `ALTER PARTITION <partition name> OF INDEX <table name>@*`. [#39750][#39750] | |||
- Support parsing the `FOR UPDATE` modifier on [`SELECT`](../v19.2/select-clause.html) clauses, treating it as a no-op, since CockroachDB's [transactions](../v19.2/transactions.html) only operate in `SERIALIZABLE` mode. [#40206][#40206] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked with Ben to flesh this out a bit. Please add links back in:
CockroachDB now supports the
FOR UPDATE
modifier onSELECT
statements for compatibility with third-party tools. It has no effect becauseSERIALIZABLE
transactions do not require explicit write locks to maintain consistency. However, this means thatSELECT FOR UPDATE
cannot be used as an advisory exclusive lock in CockroachDB, as used by some tools.
releases/v19.2.0-beta.20190826.md
Outdated
- [`cockroach dump`](../v19.2/sql-dump.html) now works properly when handling [`INTERLEAVED`](../v19.2/interleave-in-parent.html) tables, printing them outside of [`CREATE TABLE`](../v19.2/create-table.html) statements. [#39486][#39486] | ||
- Fixed internal errors generated during execution of some complicated cases of [correlated subqueries](../v19.2/subqueries.html#correlated-subqueries). [#39818][#39818] | ||
- Using `ORDER BY` inside aggregation functions is now fully supported. [#40242][#40242] | ||
- Replicas can now be moved between stores without entering an intermediate configuration that violates the [zone constraints](../v19.2/configure-replication-zones.html). Violations may still occur during zone config changes, [decommissioning](../v19.2/remove-nodes.html), and in the presence of dead nodes. [#40284][#40284] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed this with @tbg. This isn't on by default yet, so we should remove from the notes for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @jseldess and @tbg)
releases/v19.2.0-beta.20190826.md, line 60 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Ideally, this should combined with the bullet about renaming
SHOW EXPERIMENTAL RANGES
, or at least come directly after.
Done.
releases/v19.2.0-beta.20190826.md, line 41 at r3 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Remove extra
v
fromvv19
.
Done.
releases/v19.2.0-beta.20190826.md, line 87 at r3 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Should
subsequent writes in that constraint
be shorted to justsubsequent writes
..?
Done.
releases/v19.2.0-beta.20190826.md, line 88 at r3 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
For
ALTER PARTITION
, I think we should link toconfigure-zone.html
.
Done.
releases/v19.2.0-beta.20190826.md, line 89 at r3 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Worked with Ben to flesh this out a bit. Please add links back in:
CockroachDB now supports the
FOR UPDATE
modifier onSELECT
statements for compatibility with third-party tools. It has no effect becauseSERIALIZABLE
transactions do not require explicit write locks to maintain consistency. However, this means thatSELECT FOR UPDATE
cannot be used as an advisory exclusive lock in CockroachDB, as used by some tools.
Done.
releases/v19.2.0-beta.20190826.md, line 91 at r3 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
nit:
pg_my_temp_schema()
Done.
releases/v19.2.0-beta.20190826.md, line 92 at r3 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
nit: Add oxford comma
Done.
releases/v19.2.0-beta.20190826.md, line 93 at r3 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
nit:
pg_get_function_identity_arguments()
Done.
releases/v19.2.0-beta.20190826.md, line 137 at r4 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Discussed this with @tbg. This isn't on by default yet, so we should remove from the notes for now.
Done.
80f5e56
to
53be8ad
Compare
53be8ad
to
7ddccb0
Compare
4b50c4e
to
70b6e2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but delayed release again.
We are aware of one crash due to a See cockroachdb/cockroach#41147 (comment) (the crash) and cockroachdb/cockroach#41171 (the fix). |
Erghh wait I'm wrong. We don't need any special handling of that issue because the fix is in. I was incorrectly thinking it was with the SHA that didn't have that fix. We've had 3 different SHAs for this release so far and it's getting confusing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @darinpp, @jseldess, @lhirata, @mjibson, and @tbg)
releases/v19.2.0-beta.20190930.md, line 13 at r13 (raw file):
- **Locality-aware backup and restore**: You can now back up or restore a subset of a table's data according to [zone configurations](../v19.2/configure-replication-zones.html) (e.g., send your EU backup partition to an EU cloud storage location). - [**Import performance improvements**](../v19.2/import.html): Internal improvements have been made to `IMPORT` to enable more efficient loading of large data sets. - **Show partitions using SQL**: CockroachDB now supports the `SHOW PARTITIONS` [statement](../v19.2/sql-statements.html), which can be used to identify partitions. It also enhances [`SHOW CREATE TABLE`](../v19.2/show-create.html) to show constraints as described.
Shouldn't we make this a link to the show partitions page?
releases/v19.2.0-beta.20190930.md, line 15 at r13 (raw file):
- **Show partitions using SQL**: CockroachDB now supports the `SHOW PARTITIONS` [statement](../v19.2/sql-statements.html), which can be used to identify partitions. It also enhances [`SHOW CREATE TABLE`](../v19.2/show-create.html) to show constraints as described. - **Productionize Vectorization Prototype**: Queries are now automatically faster for users. This work expands upon the SQL Vectorization Prototype and allows it to be used in production. Note, this does not cover the long-tail of features necessary to use vectorization on all queries. Vectorized execution is turned on by default for a subset of queries and default back to DistSQL execution for unsupported queries - **Improve Streaming Behavior on JDBC Driver**: PostgreSQL wire protocol cursors have been implemented. As a result, PGJDBC is able to use streaming behavior to return pagination related results.
nit: pagination-related
releases/v19.2.0-beta.20190930.md, line 17 at r13 (raw file):
- **Improve Streaming Behavior on JDBC Driver**: PostgreSQL wire protocol cursors have been implemented. As a result, PGJDBC is able to use streaming behavior to return pagination related results. - [**Improve partitioning user experience**](../v19.2/partitioning.html): CockroachDB now prevents users from specifying a non-partitioned secondary index on a partitioned table by default to improve performance. Users will have the ability to override this default as it may be necessary in some rare use cases. Additionally, users can now specify the same name for the partition for tables and for all corresponding indexes. - [**Improve setting of zone configs via SQL**](../v19.2/configure-replication-zones.html): You can now use the CLI or SQL shell to retrieve locality. [`ALTER TABLE`](../v19.2/alter-table.html) now returns an error when users select conflicting or impossible zone constraints due to user error.
Is this the right place to link people? I'm confused by us mentioning retrieving locality from the CLI here...
releases/v19.2.0-beta.20190930.md, line 19 at r13 (raw file):
- [**Improve setting of zone configs via SQL**](../v19.2/configure-replication-zones.html): You can now use the CLI or SQL shell to retrieve locality. [`ALTER TABLE`](../v19.2/alter-table.html) now returns an error when users select conflicting or impossible zone constraints due to user error. - **Make it easy to focus queries on partitioned data**: CockroachDB now automatically limits a query to only the applicable [partition](../v19.2/partitioning.html) without having to specify the particular partition for a geo-distributed table. This prevents the query from conducting a full table scan. - **Improve decommissioning, recommissioning, and recovery of killed nodes**: Improved ability to change cluster membership during expected ([decommissioning](../v19.2/remove-nodes.html), [recommissioning](../v19.2/remove-nodes.html#recommission-nodes)) and unexpected (killed nodes) events without impact stability or performance.
I'm not sure what "ability" we're referencing here. @ericharmeling, do you know?
The following callout at the top would be useful, probably even necessary:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @darinpp, @jseldess, @knz, @mjibson, and @tbg)
releases/v19.2.0-beta.20190930.md, line 13 at r13 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Shouldn't we make this a link to the show partitions page?
Yes. Added. This was put in before I wrote up that page.
releases/v19.2.0-beta.20190930.md, line 15 at r13 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
nit:
pagination-related
Done.
releases/v19.2.0-beta.20190930.md, line 17 at r13 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
Is this the right place to link people? I'm confused by us mentioning retrieving locality from the CLI here...
Yeah it doesn't make sense to have that sentence in there. Removed it.
releases/v19.2.0-beta.20190930.md, line 19 at r13 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
I'm not sure what "ability" we're referencing here. @ericharmeling, do you know?
I don't know... I'm going to just reword, as Lauren is OOO today for clarification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r8, 1 of 4 files at r9, 1 of 1 files at r12, 2 of 2 files at r14.
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @darinpp, @jseldess, @mjibson, and @tbg)
releases/v19.2.0-beta.20190930.md, line 19 at r13 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
I don't know... I'm going to just reword, as Lauren is OOO today for clarification.
This bullet point (changes during decommissioning) is not yet true! It will be in the final 19.2 release but not in this beta.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @darinpp, @jseldess, @mjibson, and @tbg)
releases/v19.2.0-beta.20190930.md, line 19 at r13 (raw file):
Previously, knz (kena) wrote…
This bullet point (changes during decommissioning) is not yet true! It will be in the final 19.2 release but not in this beta.
Removed.
15b08f4
to
b1c2991
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @darinpp, @jseldess, @knz, @lhirata, @mjibson, and @tbg)
_config_base.yml, line 41 at r15 (raw file):
start_time: 2018-08-12 15:10:52.34274101 +0000 UTC v19.2: name: v19.2.0-beta.20190930
This needs to be just v19.2.0
as it's used in the version drop-down.
b1c2991
to
3091631
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @darinpp, @jseldess, @knz, @mjibson, and @tbg)
_config_base.yml, line 41 at r15 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
This needs to be just
v19.2.0
as it's used in the version drop-down.
Done.
Closes #5311.
SHA: cockroachdb/cockroach@250f4c3